[WIP] Use Rails credentials instead of deprecated and removed secrets #553
Conversation
Rails 7.1 removes access to modifying secrets as we should be moved over to rails credentials. Here we describe how to setup these rails crednetials for the purpose of recording VCR cassettes. See also: ManageIQ/manageiq-providers-autosde#253
| def credentials_awesome_cloud_host | ||
| @credentials_awesome_cloud_host ||= Rails.application.credentials.awesome_cloud_host || "awesome-cloud-host" | ||
| end |
There was a problem hiding this comment.
We didn't have a "host" in the old examples (this was modeled after a public-cloud so no hostname needed)
| end | ||
|
|
||
| def credentials_awesome_cloud_user | ||
| @credentials_awesome_cloud_user ||= Rails.application.credentials.awesome_cloud_user || "awesome-cloud-user" |
There was a problem hiding this comment.
Should this be Rails.application.credentials.awesome_cloud&.access_key
There was a problem hiding this comment.
Thanks, I'm trying to generalize them. Does that make sense for a provider that uses user/password authentication? If so, I can do that.
There was a problem hiding this comment.
Well two things, one I think even if there was a user: "..." it would be Rails.application.credentials.awesome_cloud.user not Rails.application.credentials.awesome_cloud_user and two the example here has access_key not user
I don't think I'd want to change the "writing a provider" example to have host/user/password because that doesn't match with the rest of the example code (there's an example connect method and an example api_client, etc...)
There was a problem hiding this comment.
Maybe in addition to editing this specific example to work with the new credentials interface we need a "recording_vcrs.md" guide that covers how to do this more generally?
| end | ||
|
|
||
| def credentials_awesome_cloud_password | ||
| @credentials_autosde_password ||= Rails.application.credentials.awesome_cloud_password || "change_me" |
There was a problem hiding this comment.
Rails.application.credentials.awesome_cloud&.secret_key
| secrets.awesome_cloud.each do |key, val| | ||
| config.define_cassette_placeholder(secrets.awesome_cloud_defaults[key]) { val } | ||
| defaults = { | ||
| "host_key" => credentials_awesome_cloud_host, |
There was a problem hiding this comment.
| "host_key" => credentials_awesome_cloud_host, |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
Checked commit jrafanie@df58ee5 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Rails 7.1 removes access to modifying secrets as we should be moved over to rails credentials. Here we describe how to setup these rails crednetials for the purpose of recording VCR cassettes.
See also: ManageIQ/manageiq-providers-autosde#253